Skip to content

Conversation

@vio
Copy link
Member

@vio vio commented Nov 9, 2025

Summary by CodeRabbit

  • New Features

    • Broadened plugin compatibility to support both Rollup and Vite plugin types.
    • Introduced typed output options to improve build integrations.
  • Chores

    • Bumped package to 2.1.9-beta.0.
    • Updated development tooling (Vite 7.2.2) and adjusted peer dependency ordering.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 9, 2025

Walkthrough

Bumps package version from 2.1.8 to 2.1.9-beta.0, adds devDependency "vite": "7.2.2", and reorders peerDependencies (moves "rolldown" before "rollup" and places "vite" last). Adds src/types.ts exporting Plugin = VitePlugin and OutputOptions = RollupOutputOptions. Updates src/plugin.ts to use type-only imports from ./types instead of importing types from rollup. No runtime logic or public API behavior changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Inspect src/types.ts to confirm exported type aliases (Plugin, OutputOptions) map to the intended upstream types.
  • Verify src/plugin.ts uses type-only imports from ./types and contains no runtime import regressions.
  • Check package.json for the version bump, added devDependency vite@7.2.2, and peerDependencies reordering.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: Add explicit plugin types' directly describes the main change: introducing explicit type aliases (Plugin and OutputOptions) to replace implicit type imports, making the PR's purpose clear and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-plugin-types

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20d7ab2 and 0f13766.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • package.json (2 hunks)
  • src/plugin.ts (1 hunks)
  • src/types.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/plugin.ts
  • src/types.ts
🔇 Additional comments (3)
package.json (3)

3-3: Beta version bump aligns with type system introduction.

The pre-release version 2.1.9-beta.0 is appropriate for introducing explicit plugin types without runtime API changes.


89-91: Clarify the intentionality of peerDependencies reordering.

The peerDependencies have been reordered (rolldown before rollup, vite last) without changing version constraints. Confirm whether this reordering reflects:

  • Support priority or stability order (e.g., beta rolldown listed first despite being unstable)
  • Alphabetical preference
  • Or an accidental change

If intentional, consider documenting the rationale in a comment or commit message for future maintainers.


82-82: Vite 7.2.2 is the current stable version.

Verification confirms that vite 7.2.2 was published to npm on November 7, 2025, making it the latest stable release. Adding vite as a devDependency is reasonable for type checking and testing VitePlugin exports, and the specified version is appropriate and current.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

socket-security bot commented Nov 9, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedvite@​7.1.11 ⏵ 7.2.298 +11008299 +2100

View full report

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

89-91: Clarify intent behind peerDependencies reordering.

The peerDependencies were reordered from [vite, rollup, rolldown] to [rolldown, rollup, vite], but version constraints remain unchanged. If this reordering follows a specific convention (alphabetical or priority-based), please confirm. If it's incidental cleanup, consider reverting to maintain consistency with common practices (e.g., peerDependencies ordered by relevance to the primary use case—Vite first for a Vite plugin).

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b3e7ab and 20d7ab2.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (2 hunks)
  • src/types.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/types.ts
🔇 Additional comments (2)
package.json (2)

3-3: Version bump to 2.1.8-beta.2 is appropriate.

The beta pre-release version aligns with the type system improvements introduced in this PR.


82-82: Vite 7.2.2 addition is well-motivated.

Adding vite as a devDependency ensures the development environment has explicit support for Vite 7.x testing and aligns with the peerDependency constraint (^7.0.0). This supports the PR objective of adding explicit plugin types.

@vio vio force-pushed the fix-plugin-types branch from 20d7ab2 to ccec640 Compare November 27, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants