Refactor _get_existing_jira_issue() and add tests
#401
+298
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webbnh
force-pushed
the
refactor-get-issue
branch
from
3bb9668 to
6f77cd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to provide proper unit test coverage for
_get_existing_jira_issue()(which would have been handy for #398...). However, that function contains flows which are too complex to test in a straightforward way, so this PR includes a refactorization of the function, splitting substantial sections into two other functions. The resulting functions are tested by exercising a series of scenarios for each one.While I am at it, I also add a unit test for the
UrlCacheclass.