Replace custom loader with @node-loaders/tsx#898
Open
remcohaszing wants to merge 1 commit intomainfrom
Open
Conversation
We need a loader to load our JSX test file. We currently use a local script, but there are several packages that do this. We don’t need to maintain our own. This replaces our custom loader with `@nodejs-loaders/tsx` by the Node.js team.
remcohaszing
added
🏡 area/internal
Member
Author
|
Apparently this doesn’t work with all Node.js versions we support. |
ChristianMurphy
approved these changes
Mar 6, 2025
Member
ChristianMurphy
left a comment
ChristianMurphy
left a comment
There was a problem hiding this comment.
Looks good to me, let's merge this when hydrogen is supported, or when we drop hydrogen support
Member
|
What's the different with using OK, it seems the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
We need a loader to load our JSX test file. We currently use a local script, but there are several packages that do this. We don’t need to maintain our own.
This replaces our custom loader with
@nodejs-loaders/tsxby the Node.js team.