Support Enterprise Managed User in userGroup Regex #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
A GitHub Enterprise customer discovered a bug in our product today (that uses
remark-github). Their code was crashing with:After a bunch of troubleshooting I discovered it's because their GitHub username has an
_(underscore) in it. Turns out although generally this is not allowed on GitHub, Enterprise Managed Users can have underscores (see official docs).This PR updates the Regex to support this and adds a unit test to catch this edge case.