Remove python 3.12 from older torch versions#2455
Merged
Conversation
Contributor
8W9aG
commented
Jul 8, 2025
8W9aG
commented
- Torch >=2.0.0<=2.1.2 doesn’t support python 12
- This causes the base image builds to error
* Torch >=2.0.0<=2.1.2 doesn’t support python 12 * This causes the base image builds to error
Member
|
Could we make this change by fixing the script? 100% guarantee a manual change gets lost within 2 weeks and we're fixing it again. Related, but #2400 fixes the cudnn version issue. I'd like to get that merged soon since I need the compatibility files for new base images and I'd prefer not to port over a parallel implementation. |
nevillelyh
approved these changes
Jul 8, 2025
Contributor
Author
|
@michaeldwan I can look into this tomorrow but right now I need this unblocked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.