chore(internal): support file uploads in run() helper#21
Merged
Conversation
dtmeadows
commented
May 9, 2025
Collaborator
Author
|
@zeke this is ready for a final review! |
zeke
approved these changes
May 14, 2025
Member
zeke
left a comment
There was a problem hiding this comment.
Looks great!
What are your thoughts on how to document replicate.run() in this client?
Collaborator
|
@zeke I will merge this PR as-is for now, and will do another pass to be sure it is aligned with the typescript client. Regarding docs, the typescript client has docs in README + some docstrings, I feel we should do the same here? And likely add an example that covers the various way to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo: