-
Notifications
You must be signed in to change notification settings - Fork 32
update docs with release create --required flag in CLI #3790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs with release create --required flag in CLI #3790
Conversation
✅ Deploy Preview for replicated-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for replicated-docs-upgrade ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bennyyang11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Co-authored-by: Andrew Lavery <laverya@umich.edu>
paigecalvert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! some small changes, details in the comments
| * `CHANNEL` is the channel ID or the case sensitive name of the channel. | ||
|
|
||
| For a complete list of options for the command, see [release create](/reference/replicated-cli-release-create). | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ note: I replaced the example with a link to the CLI command reference page where users can see all the options. This just helps avoid cluttering step-by-step procedures with too many options
| replicated release create [flags] | ||
| ``` | ||
|
|
||
| ### Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These replicated cli docs are automatically generated when a new version of the CLI is released
So, these changes lgtm, but they'll be overwritten with whatever's in the cli help text
|
|
||
| * Use the `--release-notes` flag to include detailed release notes in markdown. | ||
|
|
||
| * For release versions that must not be skipped during upgrades (such as versions that include a required database migration), use the `--required` flag to mark the release as required. This flag can be used with both `release create --promote` and `release promote` commands. For more information about required releases, see [Required Releases](/vendor/releases-about#required-releases) in _About Channels and Releases_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added an xref here
Shortcut story: https://app.shortcut.com/replicated/story/133212/release-create-command-should-also-support-required-flag-if-promoted-flag-used
We have a PR to un-hide the
release create--requiredflag, which already existed (and works), but was hidden from the CLI docs. This updates the product documentation as well.https://deploy-preview-3790--replicated-docs.netlify.app/reference/replicated-cli-release-create