React 19.2 APIs #149
Open
React 19.2 APIs #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
reviewed
Jan 20, 2026
| [Read more on the React Documentation](https://react.dev/reference/react/Activity) | ||
| */ | ||
| module Activity = { | ||
| type mode = [#visible | #hidden] |
Member
There was a problem hiding this comment.
I wonder if we shouldn't rather do
type mode =
| @as("visible") Visible
| @as("hidden") Hidden
?
I know that's not how we did it for domProps and also not for the React Native bindings, but I think that was because @as for variant constructors was not available at the time of their writing.
In general, these days I would only use polymorphic variants instead of normal variants when there is a good reason to do so.
One example for use of normal variants everywhere are the rescript-mui bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the APIs described on the changelog
<Activity>useEffectEventcacheSignal=> I don't plan to do it on this PR, because other RSC stuffs are missing