2.6 add jetty graceful shutdown #1452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thboileau
commented
Feb 23, 2025
| <artifactId>jetty-http3-client-transport</artifactId> | ||
| <version>${lib-jetty-version}</version> | ||
| </dependency> | ||
| <dependency> |
Contributor
Author
There was a problem hiding this comment.
useful to get debug logs
thboileau
commented
Feb 23, 2025
| && sslEndPoint.getSslSessionData().peerCertificates() != null) { | ||
| result = Arrays.asList(sslEndPoint.getSslSessionData().peerCertificates()); | ||
| } else { | ||
| getLogger().fine("SslEndpoint has no peer certificate"); |
thboileau
force-pushed
the
2.6_add-jetty-graceful-shutdown
branch
from
598bf2b to
c03e1fc
Compare
thboileau
commented
Feb 23, 2025
| default: | ||
| httpTransport = new HttpClientTransportOverHTTP(); | ||
| break; | ||
| case "HTTP2": |
Contributor
Author
There was a problem hiding this comment.
grrrr, format issue
thboileau
commented
Feb 23, 2025
| import org.eclipse.jetty.server.Request; | ||
| import org.eclipse.jetty.server.Response; | ||
| import org.eclipse.jetty.server.ServerConnector; | ||
| import org.eclipse.jetty.server.*; |
Contributor
Author
There was a problem hiding this comment.
oops, code style issue
thboileau
force-pushed
the
2.6_add-jetty-graceful-shutdown
branch
from
c03e1fc to
0c6ba34
Compare
thboileau
force-pushed
the
2.6_add-jetty-graceful-shutdown
branch
from
0c6ba34 to
058dee8
Compare
jlouvel
approved these changes
Feb 24, 2025
jlouvel
approved these changes
Feb 24, 2025
Collaborator
jlouvel
left a comment
jlouvel
left a comment
There was a problem hiding this comment.
Great contribution, thanks @thboileau
added 2 commits
February 24, 2025 21:32
…m scratch than the ones based on Jetty client
jlouvel
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim
Add support of the graceful shutdown to the Jetty server.
Check-list
DO NOT REVIEW