isInvalid 확인에 캐싱을 추가하고 프로퍼티로 관리해 생성자에서 처리하도록 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavinAhn
reviewed
Mar 26, 2025
src/common/tts/TTSPiece.es6
Outdated
| valid = false; | ||
| break; | ||
| if (el && el.nodeType === Node.ELEMENT_NODE) { | ||
| if (el._cachedEmptyState !== undefined) { |
Collaborator
There was a problem hiding this comment.
이전에는 isInvalid()가 여러번 계산될 수 있었고 지금은 생성 시점에 한번만 계산하게 했기 때문에 _cachedEmptyState는 필요 없지 않나요?
parentElement가 여러 TTSPiece에 속할 경우를 가정한 걸까요?
Contributor
Author
There was a problem hiding this comment.
parentElement가 여러 TTSPiece에 속할 경우를 가정한 걸까요?
앗 아니요...
캐싱하던거 지난 커밋걸 가져와 그대로 사용하다보니 그랬는데 생각해보니 _cachedEmptyState는 필요없을 것 같아요.
Collaborator
There was a problem hiding this comment.
구두로 이야기한것)
DV: 근데.. Elemet 안에 여러 Piece(Node)가 있으면 그 만큼 isInvalid가 불리는거고 호출 횟수를 줄이려했던 개선에서 벗어나는거라 문제가 발생할 수 있지 않을까요?
KT: 하지만 잘 됩니다 (?)
DV: 오?
KT: 문제 생기면 그 다음 단계로 가는 걸로!
Contributor
Author
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋ TEXT_NODE로 잘못 들어간 것 수정했어요. 수정한 후에도 잘 됩니다!
DavinAhn
approved these changes
Mar 26, 2025
YSYoon
approved these changes
Mar 26, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 및 작업내용