Pull based config changes from admin to runtime #8548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-anshul
changed the title
begelundmuller
requested changes
Dec 29, 2025
Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
k-anshul
commented
Dec 30, 2025
k-anshul
commented
Dec 30, 2025
begelundmuller
requested changes
Dec 30, 2025
runtime/runtime.go
Outdated
| } | ||
|
|
||
| func (r *Runtime) ReloadConfig(ctx context.Context, instanceID string) error { | ||
| return r.configReloader.reloadConfig(ctx, instanceID) |
Contributor
There was a problem hiding this comment.
- Need to check
if r.configReloader != nil { - Also, shouldn't it run in the background? Since the
adminservice may have to call this on many runtimes at a time, and since the runtime already is capable of pulling config in the background, it'd be nice for it to just be a quick op
Member
Author
There was a problem hiding this comment.
- It will be nice to capture the error and forward it to admin. The status of the reloads can be checked in river jobs history as well. It can also reload if required.
Since the config reloads now happen async in admin service so it should be fine to introduce some latency.
But happy to make this change if you think otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/rilldata/issue/PLAT-324/switch-to-pull-instead-of-push-for-config-changes-from-admin-to
Checklist: