35679 create pg publication and pg index #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed incorrect generation of Index objects using qualified column names or Text() objects, which led to broken SQL DDL and database errors. - Ensured all Index columns are created with unqualified column names and as actual Column objects, not Text() expressions, resolving issues with CREATE INDEX syntax. - Added logic to correctly handle special Postgres index operator classes (e.g., gin_trgm_ops) when needed, ensuring compatibility with extensions like pg_trgm. - Refactored index handling to avoid assigning to read-only properties (e.g., Index.columns), instead removing and recreating indexes as required. - Improved generator output to set table schema and comments where necessary. - General cleanup and clarification of index and table argument rendering. Fixes issues with model-generated DDL not matching the database schema and errors when running Base.metadata.create_all().
sweh
approved these changes
Jul 16, 2025
Member
sweh
left a comment
sweh
left a comment
There was a problem hiding this comment.
Nichts auffälliges gesehen, Tests gehen noch kaputt, aber das ignorieren wir hier vermutlich, ist ja eh nur für zwei Mal (ClaimX und MCI)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #.
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchCHANGES.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.