Skip to content

Conversation

@NathanFlurry
Copy link
Member

No description provided.

@railway-app
Copy link

railway-app bot commented Jan 28, 2026

🚅 Deployed to the rivet-pr-4055 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud 😴 Sleeping (View Logs) Web Jan 28, 2026 at 10:04 am
frontend-inspector 😴 Sleeping (View Logs) Web Jan 28, 2026 at 10:04 am
website 😴 Sleeping (View Logs) Web Jan 28, 2026 at 10:03 am
mcp-hub ✅ Success (View Logs) Web Jan 28, 2026 at 9:53 am

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Jan 28, 2026

PR Review: Migrate Docker Image from rivetkit/engine to rivetdev/engine

Summary

This PR migrates the Docker image namespace from rivetkit/engine to rivetdev/engine. The changes are mostly straightforward and systematic, but there's a critical unintended change that needs to be addressed.


🚨 Critical Issue

Unintended Removal of ClickHouse Configuration

The PR inadvertently removes important ClickHouse configuration schema definitions from engine/artifacts/config-schema.json:

  • Removed provision_users property from ClickHouse configuration (35 lines deleted)
  • Removed ClickHouseUser and ClickHouseUserRole type definitions

Impact: This is problematic because:

  1. The provision_users field is still actively used in dev config files:
    • engine/docker/dev/rivet-engine/config.jsonc
    • All multinode and multidc config files (16+ files)
  2. Removing this from the schema will break validation for existing configurations
  3. This appears unrelated to the Docker image rename and likely snuck in accidentally

Recommendation: Revert the changes to engine/artifacts/config-schema.json entirely. This file should not be modified as part of this PR since the schema changes are unrelated to the Docker image migration.


✅ Code Quality

Docker Image Migration

The systematic replacement of rivetkit/enginerivetdev/engine is thorough and correct:

  • CI/CD: ✅ GitHub Actions workflows updated (.github/workflows/release.yaml:202-229)
  • Documentation: ✅ All docs updated consistently
    • README.md:129
    • website/src/content/docs/self-hosting/*.mdx
  • Build Scripts: ✅ All scripts updated
    • justfile:7-15
    • scripts/docker/build-push-release.sh:8
    • scripts/release/*.ts
  • Marketing: ✅ Website components updated (HostingSection.tsx:54)

Best Practices

  • Changes follow conventional commit format: chore: migrate docker from rivetkit/engine -> rivetdev/engine
  • Comprehensive coverage across documentation, scripts, and CI ✅
  • No breaking API changes for users (just image name) ✅

🔍 Additional Checks Needed

1. Verify Docker Hub Access

Ensure the CI has proper credentials for pushing to rivetdev/engine:

  • Check that DOCKER_CI_ACCESS_TOKEN secret has write access to rivetdev organization
  • Verify both full and slim variants can be pushed

2. Check for Remaining References

There are 622 files with rivetkit/engine references (mostly generated docs). While many are intentional (TypeDoc output), verify none are critical:

# Spot check some files to ensure they're just generated artifacts
grep -r "rivetkit/engine" website/public/typedoc/

3. Update Docker Hub Repository

  • Ensure rivetdev/engine repository exists on Docker Hub
  • Consider adding a deprecation notice to rivetkit/engine repository
  • Set up automated description/README sync if needed

📋 Testing Recommendations

Before merging:

  1. Build test: Ensure Docker images build successfully with new tags

    just docker-build
    docker images | grep rivetdev/engine
  2. Schema validation: After reverting config-schema.json, verify dev configs still validate:

    # Test with a dev config that uses provision_users
    cargo run -- validate-config engine/docker/dev/rivet-engine/config.jsonc
  3. Release dry-run: Test release scripts with new image name (if possible)


📝 Summary

Must Fix:

  • ❌ Revert all changes to engine/artifacts/config-schema.json (unintended deletion of ClickHouse config)

Looks Good:

  • ✅ Systematic Docker image rename across all files
  • ✅ Documentation updates are comprehensive
  • ✅ CI/CD configuration properly updated
  • ✅ Commit message follows conventions

Nice to Have:

  • 🔍 Verify Docker Hub credentials before merge
  • 🔍 Add deprecation notice to old rivetkit/engine repository
  • 🧪 Test image build with new name locally

Once the config schema changes are reverted, this PR will be ready to merge. The Docker image migration itself is clean and well-executed! 🎯

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 28, 2026

More templates

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4055

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4055

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@4055

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4055

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4055

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4055

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4055

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4055

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4055

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4055

commit: 4e854cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants