-
Notifications
You must be signed in to change notification settings - Fork 150
chore: migrate docker from rivetkit/engine -> rivetdev/engine #4055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: migrate docker from rivetkit/engine -> rivetdev/engine #4055
Conversation
|
🚅 Deployed to the rivet-pr-4055 environment in rivet-frontend
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: Migrate Docker Image from rivetkit/engine to rivetdev/engineSummaryThis PR migrates the Docker image namespace from 🚨 Critical IssueUnintended Removal of ClickHouse ConfigurationThe PR inadvertently removes important ClickHouse configuration schema definitions from
Impact: This is problematic because:
Recommendation: Revert the changes to ✅ Code QualityDocker Image MigrationThe systematic replacement of
Best Practices
🔍 Additional Checks Needed1. Verify Docker Hub AccessEnsure the CI has proper credentials for pushing to
2. Check for Remaining ReferencesThere are 622 files with # Spot check some files to ensure they're just generated artifacts
grep -r "rivetkit/engine" website/public/typedoc/3. Update Docker Hub Repository
📋 Testing RecommendationsBefore merging:
📝 SummaryMust Fix:
Looks Good:
Nice to Have:
Once the config schema changes are reverted, this PR will be ready to merge. The Docker image migration itself is clean and well-executed! 🎯 |

No description provided.