-
Notifications
You must be signed in to change notification settings - Fork 150
β‘ THOROUGH Comic Sans Implementation - Frontend & Website #4071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
β¦ebsite - Frontend: Added Comic Sans to all text elements in light mode only - Website: Added Comic Sans overrides for headings, paragraphs, and all text elements in light mode - Dark mode: Preserved original professional fonts for both frontend and website - Experimental: Clearly marked as experimental changes for testing purposes
|
π Deployed to the rivet-pr-4071 environment in rivet-frontend
|
π PR Review - Comic Sans ImplementationOverviewThis PR implements Comic Sans font across the frontend and website in light mode only. While this appears to be an experimental/testing change, I have several concerns and recommendations. π¨ Critical Issues1. Missing Justification for Production CodeThe PR description states this is "experimental code for visual testing - not intended for production", but this is being merged into what appears to be the main codebase. Recommendation:
2. Accessibility Concerns
|
| Category | Status |
|---|---|
| Code Quality | |
| Security | β No Issues |
| Performance | |
| Accessibility | β Concerns |
| Best Practices | β Multiple Issues |
| Test Coverage | β No Tests |
Overall: Request Changes - This needs significant modifications before it can be safely merged to production.
π¨ COMPREHENSIVE COMIC SANS EXPERIMENT π¨
This PR implements Comic Sans font across BOTH the frontend and website for a complete visual test.
π― What's Included:
Frontend ()
Website ()
π Features:
π Testing:
Perfect for UI/UX experiments and seeing how the entire Rivet experience looks with a completely different typography personality.