Skip to content

chore(frontend): add default vite sentry url#4163

Closed
NathanFlurry wants to merge 1 commit into02-09-chore_update_exmaplesfrom
02-09-chore_frontend_add_default_vite_sentry_url
Closed

chore(frontend): add default vite sentry url#4163
NathanFlurry wants to merge 1 commit into02-09-chore_update_exmaplesfrom
02-09-chore_frontend_add_default_vite_sentry_url

Conversation

@NathanFlurry
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member Author

NathanFlurry commented Feb 10, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Feb 10, 2026
11 tasks
@claude
Copy link

claude bot commented Feb 10, 2026

Pull Request Review

Summary

This PR updates the vite-plugin-srvx dependency from a pre-release version (pkg.pr.new link) to the stable published version ^1.0.2 across all example packages, and adds a default empty value for VITE_APP_SENTRY_TUNNEL in the frontend environment configuration.

Changes Reviewed

1. Dependency Updates (25 examples)

  • Updated vite-plugin-srvx from https://pkg.pr.new/rivet-dev/vite-plugin-srvx@10 to ^1.0.2
  • Removed the pkg.pr.new override from root package.json
  • All examples now use the published npm package

2. Frontend Configuration

  • Added VITE_APP_SENTRY_TUNNEL= to frontend/.env (frontend/.env:11)
  • Updated third-party-providers.tsx to handle empty string: tunnel: getConfig().sentry?.tunnel || undefined (frontend/src/components/third-party-providers.tsx:42)

3. Lock File

  • Large pnpm-lock.yaml update (2471 additions, 1183 deletions) - expected for dependency version change

Code Quality ✅

Strengths:

  • Consistent updates across all affected packages
  • Proper alphabetical ordering of dependencies maintained in most files
  • Clean migration from pre-release to stable version

Minor Issue:

  • Some inconsistent ordering in raw-websocket-handler where srvx appears after react-dom instead of being alphabetically sorted

Potential Issues ⚠️

1. Sentry Tunnel Configuration (Medium Priority)

The change at frontend/src/components/third-party-providers.tsx:42 converts empty strings to undefined:

tunnel: getConfig().sentry?.tunnel || undefined,

Issue: This uses a logical OR operator, which treats empty strings as falsy. While this works, it is better to be explicit about the intention.

Recommendation: Document why empty string to undefined conversion is needed, or use more explicit handling.

Rationale: The current implementation works but may be confusing since the .env file explicitly sets VITE_APP_SENTRY_TUNNEL= (empty string). The code should clearly document whether empty strings are intentional nulls.

2. Missing PR Description (High Priority)

The PR description is completely empty - only the template remains unchecked. For a change affecting 29 files and 2500+ lines in the lock file, this should include:

  • Why the migration from pkg.pr.new to npm?
  • What testing was performed?
  • Are there any breaking changes in vite-plugin-srvx 1.0.2?
  • Why is the Sentry tunnel being set to empty by default?

Performance Considerations ✅

No performance concerns. The dependency update is a minor version bump and the Sentry tunnel change is a simple configuration adjustment.


Security Concerns ✅

Positive:

  • Moving from a pkg.pr.new pre-release to a published npm package is a security improvement (better supply chain security)
  • The Sentry configuration change does not introduce security issues

Note: The .env file contains public-facing tokens (PostHog API key) which is correctly documented as safe to commit.


Test Coverage ❓

Missing Information:

  • No indication of how this was tested
  • Were the examples manually tested after the upgrade?
  • Did the Vercel examples regeneration complete successfully?

Recommendation: Run ./scripts/vercel-examples/generate-vercel-examples.ts to ensure Vercel examples are in sync, as per CLAUDE.md guidelines.


CLAUDE.md Compliance

Following the repository CLAUDE.md guidelines:

✅ Dependency versions properly updated
⚠️ PR description template not filled out (should document changes)
❓ Testing not documented
✅ Alphabetical ordering mostly maintained
⚠️ No indication of running pnpm install after regenerating examples


Recommendations

Before Merging:

  1. Fill out the PR description with:

    • Reason for migrating from pkg.pr.new to published version
    • Testing performed on the examples
    • Any breaking changes or migration notes
  2. Fix the Sentry tunnel handling - Either:

    • Document why empty string to undefined conversion is needed
    • Or use more explicit handling for empty strings
  3. Verify Vercel examples - Run the Vercel examples generator and ensure no type errors

  4. Test at least 2-3 examples to verify the plugin upgrade does not break functionality

Optional:

  • Fix alphabetical ordering in examples/raw-websocket-handler/package.json

Overall Assessment

This is a straightforward dependency update that improves the project by using stable published packages instead of pre-release versions. The changes are consistent and well-scoped. However, the PR lacks documentation and testing information, which should be addressed before merging.

Status: Approve with Minor Changes ✅ (pending PR description and testing verification)

@NathanFlurry NathanFlurry marked this pull request as ready for review February 10, 2026 08:40
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 10, 2026

Merge activity

  • Feb 10, 8:45 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Feb 10, 8:46 AM UTC: CI is running for this pull request on a draft pull request (#4166) due to your merge queue CI optimization settings.
  • Feb 10, 8:48 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #4081.
  • Feb 10, 8:48 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #4081.
  • Feb 10, 7:35 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Feb 10, 7:36 PM UTC: CI is running for this pull request on a draft pull request (#4167) due to your merge queue CI optimization settings.
  • Feb 10, 7:36 PM UTC: Merged by the Graphite merge queue via draft PR: #4167.

graphite-app bot pushed a commit that referenced this pull request Feb 10, 2026
# Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

## How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
@NathanFlurry NathanFlurry force-pushed the 02-09-chore_frontend_add_default_vite_sentry_url branch from f45f5d5 to eb969c8 Compare February 10, 2026 19:25
@NathanFlurry NathanFlurry force-pushed the 02-09-chore_update_exmaples branch from d03839f to b249fff Compare February 10, 2026 19:25
graphite-app bot pushed a commit that referenced this pull request Feb 10, 2026
# Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

## How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
@graphite-app graphite-app bot closed this Feb 10, 2026
@graphite-app graphite-app bot deleted the 02-09-chore_frontend_add_default_vite_sentry_url branch February 10, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant