Print warning when custom validators are detected#5290
Draft
vithushar wants to merge 7 commits intormosolgo:masterfrom
Draft
Print warning when custom validators are detected#5290vithushar wants to merge 7 commits intormosolgo:masterfrom
vithushar wants to merge 7 commits intormosolgo:masterfrom
Conversation
Owner
|
Hey, thanks for looking into this. What if we made Implementation-wise, it'd be very much like #5263. What do you think? |
Contributor
Author
I'm very much on board with that. Let's do it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Custom validators with I/O operations may fail unexpectedly due to GraphQL's default validate_timeout setting. Long-running I/O operations may not be terminated midway, resulting in unpredictable behavior.
See these PRs for more context:
Manual timeout implementation: #5263
Validate_timeout default value implementation: #5258
We should make the risk of adding I/O bound custom validators more "in your face" in the gem for consumers.
solution
Print a warning when a custom validator is registered.