Add github actions and Typescript declarations #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As someone using TS, I'd love to see this merged. 👍 |
|
I would love to see this merged |
Author
|
when not is merged use |
|
Thanks |
|
Would love to see this merged as well! 🙏 |
|
This would also be useful to us 🙏 |
Author
|
Waiting for main maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm bringing some additions to your fork, I added Github Actions to run the Test Build, and also add Typescript declarations for people using typescript.
I also removed some dependencies that I noticed were not being used ("segfault-handler" and the "nyc").
I increased the mocha time reasonably but it still fails, due to time out.
I am rewriting export to CommonJS and exporting in ESM from commonjs import.