Skip to content

Conversation

@robertvansteen
Copy link
Contributor

@robertvansteen robertvansteen commented Dec 30, 2024

This fixes deprecation warning in PHP 8.4

Deprecated: RobinIngelbrecht\PHPUnitCoverageTools\MinCoverage\MinCoverageResult::mapFromRulesAndMetrics(): Implicitly marking parameter $metricTotal as nullable is deprecated, the explicit nullable type must be used instead

@robiningelbrecht
Copy link
Owner

@robertvansteen thanks for you contribution!

Would following work as well?

?CoverageMetric $metricTotal

@robertvansteen
Copy link
Contributor Author

@robertvansteen thanks for you contribution!

Would following work as well?

?CoverageMetric $metricTotal

That would also work :)

@robiningelbrecht robiningelbrecht merged commit db5534e into robiningelbrecht:master Dec 30, 2024
4 checks passed
@codecov
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (a4d5e78) to head (e582c45).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master   #18       +/-   ##
==========================================
- Coverage     99.39%     0   -99.40%     
==========================================
  Files             9     0        -9     
  Lines           330     0      -330     
==========================================
- Hits            328     0      -328     
+ Misses            2     0        -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants