fix: holt-winters train.go runs off end of series and panics if start > 0#73
Open
kevinroundy wants to merge 1 commit intorocketlaunchr:masterfrom
Open
fix: holt-winters train.go runs off end of series and panics if start > 0#73kevinroundy wants to merge 1 commit intorocketlaunchr:masterfrom
kevinroundy wants to merge 1 commit intorocketlaunchr:masterfrom
Conversation
start needs to be replaced with y_start.
Collaborator
|
I think you may be using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
holt-winters train.go runs off end of series and panics if Range.Start
The indexing limits used in the for loop are intended for hw.sf.Values, but since we are indexing into "y" instead, we run off the end of the array and panic if start > 0.
To fix this, we create a y_start and y_end and use those as limits and within the function in place of start and end.