fix: Extract parseRssItems into its own file#25
Merged
Conversation
now returns raw XML string when no callback is passed
- updated non browser calls - added jest config and test
removed logs
added book_large_image_url to goodreads feed
- updated proxy - updated libs
…-feed-api into release/patch
Replaces xml2js-based parsing with a generic Cheerio-powered RSS parser. Adds type-safe selector maps, new helpers for Substack and Goodreads feeds, and improves error handling. Updates README and type definitions, introduces new tests, and adds Cheerio as a dependency. Updates GitHub workflows for versioning and release, and adds a version check workflow.
Move the parseRssItems implementation out of lib/index.ts into a new lib/parseRssItems.ts and update lib/index.ts to re-export parseRssItems, goodreads, and substack. Also simplify the Vite build entry to use the single barrel ./lib/index.ts instead of listing multiple entry files, so the library is built from the unified exports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the parseRssItems implementation out of lib/index.ts into a new lib/parseRssItems.ts and update lib/index.ts to re-export parseRssItems, goodreads, and substack. Also simplify the Vite build entry to use the single barrel ./lib/index.ts instead of listing multiple entry files, so the library is built from the unified exports.