Skip to content

Ht2 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maximgatilin wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Ht2 #16

maximgatilin wants to merge 4 commits into from

Conversation

@maximgatilin
Copy link

@maximgatilin maximgatilin commented Oct 25, 2017

@romabelka
Вопросы:

  1. Нужно ли было обрабатывать ошибки формы, пришедшие с firebase или будем делать это позже?
  2. Нужно ли было в тестах отправлять запросы к firebase, или можно оставить mock данные?

@romabelka
Copy link
Owner

romabelka commented Oct 26, 2017

  1. Нет, дальше мы не будем на это останавливаться, верю что с этим вы вполне разберетесь)
  2. Не надо, здесь идея в том, что можно обойтись без моков

romabelka
romabelka reviewed Oct 26, 2017
View reviewed changes
src/ducks/auth.js
try {
const user = yield call([auth, auth.signInWithEmailAndPassword], payload.email, payload.password)

yield put({
Copy link
Owner

@romabelka romabelka Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В общем случае все правильно, хотя нам достаточно onAuthStateChange

src/ducks/auth.test.js
@@ -0,0 +1,146 @@
import {
Copy link
Owner

@romabelka romabelka Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошо, но в идеале можно еще и редюсер потестить

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romabelka romabelka romabelka left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maximgatilin @romabelka