[Minuit2] Fix external index usage in analytical Hessian #20936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix external index usage in analytical Hessian and also add a unit test to cover this former bug.
Test Results 22 files 22 suites 3d 10h 50m 44s ⏱️ Results for commit 8f29655. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix external index usage in analytical Hessian and also add a unit test to cover this former bug.
This problem exists since the introduction of external Hessians to Minuit2 in 888a767 in the ROOT 6.28 development cycle..
I discovered this bug while investigating #20913.