Skip to content

Silence -Wdeprecated-declarations in diff_drive_controller#2139

Open
christophfroehlich wants to merge 1 commit intomasterfrom
silence_deprecations_diff_drive
Open

Silence -Wdeprecated-declarations in diff_drive_controller#2139
christophfroehlich wants to merge 1 commit intomasterfrom
silence_deprecations_diff_drive

Conversation

@christophfroehlich
Copy link
Member

Silence warnings from deprecated methods being called in deprecated methods which have been introduced with #1854

/workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/src/odometry.cpp: In member function ‘bool diff_drive_controller::Odometry::update(double, double, const rclcpp::Time&)’:
/workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/src/odometry.cpp:71:21: warning: ‘bool diff_drive_controller::Odometry::updateFromVelocity(double, double, const rclcpp::Time&)’ is deprecated: Replaced by bool update_from_vel(double left_vel, double right_vel, double dt). [-Wdeprecated-declarations]
   71 |   updateFromVelocity(left_wheel_est_vel, right_wheel_est_vel, time);
      |   ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/src/odometry.cpp:21:
/workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/include/diff_drive_controller/odometry.hpp:49:8: note: declared here
   49 |   bool updateFromVelocity(double left_vel, double right_vel, const rclcpp::Time & time);
      |        ^~~~~~~~~~~~~~~~~~
/workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/src/odometry.cpp: In member function ‘bool diff_drive_controller::Odometry::updateFromVelocity(double, double, const rclcpp::Time&)’:
/workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/src/odometry.cpp:108:17: warning: ‘void diff_drive_controller::Odometry::integrateExact(double, double)’ is deprecated: Replaced by void integrate(double linear_vel, double angular_vel, double dt). [-Wdeprecated-declarations]
  108 |   integrateExact(linear, angular);
      |   ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
/workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/include/diff_drive_controller/odometry.hpp:80:8: note: declared here
   80 |   void integrateExact(double linear, double angular);
      |        ^~~~~~~~~~~~~~
/workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/src/odometry.cpp: In member function ‘void diff_drive_controller::Odometry::updateOpenLoop(double, double, const rclcpp::Time&)’:
/workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/src/odometry.cpp:155:17: warning: ‘void diff_drive_controller::Odometry::integrateExact(double, double)’ is deprecated: Replaced by void integrate(double linear_vel, double angular_vel, double dt). [-Wdeprecated-declarations]
  155 |   integrateExact(linear * dt, angular * dt);
      |   ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
/workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/include/diff_drive_controller/odometry.hpp:80:8: note: declared here
   80 |   void integrateExact(double linear, double angular);
      |        ^~~~~~~~~~~~~~
/workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/src/odometry.cpp: In member function ‘void diff_drive_controller::Odometry::integrateExact(double, double)’:
/workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/src/odometry.cpp:206:25: warning: ‘void diff_drive_controller::Odometry::integrateRungeKutta2(double, double)’ is deprecated: Replaced by void integrate(double linear_vel, double angular_vel, double dt). [-Wdeprecated-declarations]
  206 |     integrateRungeKutta2(linear, angular);
      |     ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
/workspaces/ros2_rolling_ws/src/ros2_controllers/diff_drive_controller/src/odometry.cpp:192:6: note: declared here
  192 | void Odometry::integrateRungeKutta2(double linear, double angular)
      |      ^~~~~~~~

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.80%. Comparing base (2c29d46) to head (c70bd59).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2139   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         151      151           
  Lines       14660    14660           
  Branches     1272     1272           
=======================================
  Hits        12433    12433           
  Misses       1766     1766           
  Partials      461      461           
Flag Coverage Δ
unittests 84.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
diff_drive_controller/src/odometry.cpp 49.12% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant