Skip to content

Improve the robustness of the TopicEndpointInfo constructor (backport #3013) #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahcorde merged 1 commit into from
Jan 12, 2026
Merged

Improve the robustness of the TopicEndpointInfo constructor (backport #3013) #3014

ahcorde merged 1 commit into from
Jan 12, 2026

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jan 12, 2026

Description

node_name, node_namespace and topic_type may be nullptr. This will result in initializing a std::string with nullptr, which will cause an exception during construction. This issue is mentioned here ros2/rosbag2#2293.

rclcpp/rclcpp/include/rclcpp/node_interfaces/node_graph_interface.hpp

Lines 59 to 62 in c85ff92

explicit TopicEndpointInfo(const rcl_topic_endpoint_info_t & info)
: node_name_(info.node_name),
node_namespace_(info.node_namespace),
topic_type_(info.topic_type),

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

N/A

This is an automatic backport of pull request #3013 done by [Mergify](https://mergify.com).

@Barry-Xu-2018 @mergify
Improve the robustness of the TopicEndpointInfo constructor (#3013)
2f2e0f4 
* Improve the robustness of the TopicEndpointInfo constructor

Signed-off-by: Barry Xu <barry.xu@sony.com>

* Improve TopicEndpointInfo constructor to validate input parameters

Signed-off-by: Barry Xu <barry.xu@sony.com>

---------

Signed-off-by: Barry Xu <barry.xu@sony.com>
(cherry picked from commit 7f783cb)
@mergify mergify bot mentioned this pull request Jan 12, 2026
Merged
@ahcorde
Copy link
Contributor

ahcorde commented Jan 12, 2026

Pulls: #3014
Gist: https://gist.githubusercontent.com/ahcorde/1016c25023dc0befdd6e5cd6e555b30d/raw/3bdb1a8a92da16603943d1c84dd2fe6e7c331b3e/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17911

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 19e443b into kilted Jan 12, 2026
2 of 3 checks passed
@ahcorde ahcorde deleted the mergify/bp/kilted/pr-3013 branch January 12, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@jmachowinski jmachowinski jmachowinski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahcorde @jmachowinski @Barry-Xu-2018