Improve the robustness of the TopicEndpointInfo constructor (backport #3013)

[mergify]

Description

node_name, node_namespace and topic_type may be nullptr. This will result in initializing a std::string with nullptr, which will cause an exception during construction. This issue is mentioned here ros2/rosbag2#2293.

rclcpp/rclcpp/include/rclcpp/node_interfaces/node_graph_interface.hpp

Lines 59 to 62 in c85ff92

	explicit TopicEndpointInfo(const rcl_topic_endpoint_info_t & info)
	: node_name_(info.node_name),
	node_namespace_(info.node_namespace),
	topic_type_(info.topic_type),

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

N/A

---

This is an automatic backport of pull request #3013 done by [Mergify](https://mergify.com).

[ahcorde]

Pulls: #3015
Gist: https://gist.githubusercontent.com/ahcorde/95fa66e5c42cd95ef6de4fa8fe2be751/raw/01f31d31c2ed5f2b55aed84277069f194175fc62/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17912

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[Barry-Xu-2018]

• Linux
  • The reason for the failure comes from the CI system itself.
  • Rerun
• Windows
  • The failed tests are not related to this PR.

    projectroot.test_publisher_subscriber__rclcpp__rmw_fastrtps_cpp
    projectroot.test_requester_replier__rclcpp__rmw_fastrtps_cpp
    projectroot.test_action_client_server__rclcpp__rmw_fastrtps_cpp
    test_communication.TestActionClientServerAfterShutdown.test_processes_finished_gracefully[Fibonacci]
    test_communication.TestActionClientServerAfterShutdown.test_processes_finished_gracefully[NestedMessage]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[Arrays]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[BasicTypes]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[BoundedPlainSequences]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[BoundedSequences]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[Builtins]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[Constants]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[Defaults]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[Empty]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[MultiNested]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[Nested]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[Strings]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[UnboundedSequences]
    test_communication.TestPublisherSubscriberAfterShutdown.test_processes_finished_gracefully[WStrings]
    test_communication.TestRequesterReplierAfterShutdown.test_processes_finished_gracefully[Arrays]
    test_communication.TestRequesterReplierAfterShutdown.test_processes_finished_gracefully[BasicTypes]
    test_communication.TestRequesterReplierAfterShutdown.test_processes_finished_gracefully[Empty]