BX-68163: feature parity for document endpoints in dotnet binding#7
Open
cransom-babelstreet wants to merge 10 commits intomasterfrom
Open
BX-68163: feature parity for document endpoints in dotnet binding#7cransom-babelstreet wants to merge 10 commits intomasterfrom
cransom-babelstreet wants to merge 10 commits intomasterfrom
Conversation
added 9 commits
February 10, 2026 09:49
asoosprecognox
left a comment
asoosprecognox
left a comment
There was a problem hiding this comment.
I haven't finished reviewing the tests yet, so I might have some comments for that as well, but I wanted to share what I found so far.
Also I really like the changes you made, great work!
Comment on lines
+21
to
+25
| public new Entities SetGenre(string genre) | ||
| { | ||
| // Genre is not supported for Entities endpoint - ignore the value | ||
| return this; | ||
| } |
There was a problem hiding this comment.
I think this should be moved to the parent class
Author
There was a problem hiding this comment.
There is a SetGenre method in the base class. This is an override because the D.O.D. on the ticket mentioned a change for that specific endpoint: "Remove genre from /entities but, for backwards compatibility, don’t throw an error if it is set."
| } | ||
| using Rosette.Api.Endpoints.Core; | ||
|
|
||
| namespace Rosette.Api.Endpoints; |
There was a problem hiding this comment.
@seth-mg as the namespaces are reworked, should we use the opportunity to remove the Rosette from it?
rosette_api/Models/JsonConverter/RecordSimilarityFieldConverter.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.