Open
Conversation
matsl
commented
Feb 5, 2026
|
|
||
| (ert-deftest hywiki-tests--wikiword-identified-in-emacs-lisp-mode () | ||
| "Verify WikiWord is identified when surrounded by delimiters in `emacs-lisp-mode'." | ||
| :expected-result :failed |
Collaborator
Author
There was a problem hiding this comment.
This is the test case that fails.
With hywiki-mode :all and WikiWord page created this in emacs-lisp-mode below
;; [[WikiWord]]
There WikiWord is not highlighted but hywiki-word-at says it is a WikiWord. Is that the expected behavior? It seems wrong. It can be reproduced manually.
Ideally tests with or without face check should behave the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Request to merge on master branch instead of rsw. Should be same as
#849 (after rebase with rsw at the time) with an update of the ChangeLog.
Why
rsw branch was merged to master so work continues here.
Includes further improvements. More tests are working now.
I also rolled back to the previous version of
hywiki-tests--word-atand changed it so that if
hywiki-word-atfinds a wikiword then if we testhighlighting
hywiki-highligted-word-atmust also find a wikiword.So that not missing highlighting indicates there is no wikiword.
That rollback causes a test to fail. I think this points to a problem
in hywiki rather than in the test, I can reproduce manually,
so I have marked it as expected failed.