Improve FILE_URL handling and logging#244
Merged
rtuszik merged 1 commit intortuszik:devfrom Feb 13, 2026
Merged
Conversation
Contributor
Author
|
I think this is ready to merge. I tested it manually, but not sure what further testing is required. |
rtuszik
requested changes
Feb 12, 2026
Owner
rtuszik
left a comment
rtuszik
left a comment
There was a problem hiding this comment.
Good PR, thank you!
Ready to merge once the sanitization suggestion is implemented!
You can also leave out the comments when self explanatory, but thats not a blocker.
Contributor
Author
|
Good spot - sorry for missing that one. I refactored the sanitising of URLs into a new method. If you are happy with that, I should squash commits before merge. |
inconsistent parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.