Fix active_job adapter for Rails 7.2 #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Contributor
|
Woudn't be better to subclass abstract class if present as done here https://github.com/rails/rails/pull/51426/files#diff-572a695cc044413e9d509392a9230f9fbe8a039518f3e438a3c88f2b6a259480 and https://github.com/rails/rails/pull/51426/files#diff-7a8b283a48704bb9acd48ba131b93d9f0ea0635c8570d7359ef063b7199845c3? |
sekrett
force-pushed
the
fix-active-job-adapter
branch
from
e6df75c to
3becbc4
Compare
Contributor
Author
|
Yeah, subclassing looks to work, I updated. Thank you. |
Contributor
|
This was added for Rails 7.2+, I think we would like to support earlier releases also. I can try to setup CI, but meanwhile, can you make this conditional somehow? |
Contributor
Author
|
Added a conditional. On Rails 8 it is not required anymore, just for 7.2. |
Member
|
@simi feel free to merge it if the conditional base class addresses your concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it a NoMethodError occurs.