Skip to content

Conversation

@cdhagmann
Copy link
Contributor

@cdhagmann cdhagmann commented May 7, 2025

This MR adds three new configuration keys (and their default values) to Sneakers.configuration that are passed through to the logger. These keys are:

  • log_rotate_age (Default: 5)
  • log_rotate_size (Default: 1048576 [1 MB])
  • log_level (Default: 'debug')

A test had to be updated to expect these keys, but I did not see a place to add testing the affect. Willing to push tests where appropriate.

#33

:pid_path => 'sneakers.pid',
:amqp_heartbeat => 30,

# Default values from serverengine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea!

@cdhagmann cdhagmann marked this pull request as draft May 7, 2025 20:11
@cdhagmann cdhagmann marked this pull request as ready for review May 7, 2025 20:40
@cdhagmann
Copy link
Contributor Author

Passes the test locally after modify a test that looks at the options hash.

@cdhagmann cdhagmann changed the title [DRAFT] Pass logger configuration values through to logger initialization Pass logger configuration values through to logger initialization May 7, 2025
@michaelklishin michaelklishin added this to the 3.3.0 milestone May 7, 2025
@michaelklishin michaelklishin merged commit 2ce8d84 into ruby-amqp:main May 7, 2025
4 checks passed
@michaelklishin
Copy link
Member

@cdhagmann thank you! How soon or how badly do you need a 3.3.0 release with this change?

@simi
Copy link
Contributor

simi commented May 7, 2025

👍

@cdhagmann
Copy link
Contributor Author

We are able to pass in a logger instance directly for the moment so we are in no rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants