Split internal extra calculation prec and BigDecimal.double_fig usage #486
+41
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigDecimal's code was mixing up BigDecimal.double_fig(must be exactly 16) and internal extra calculation prec(could be any number around 10).
This change will clearly split this two essentially different constant usage.
Examples
This example should use double_fig because Float has double_fig precision. It must be 16.
This example should use EXTRA_PREC, a safe factor to reduce division/rounding error.
The value is completely unrelated to Float's internal precision. It can be reduced to 12, 10, 8 or something else in the future.