Skip to content

Implement OpenSSL::PKey#size #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
herwinw wants to merge 1 commit into
base: master
Choose a base branch
from
+42 −0
Open

Implement OpenSSL::PKey#size #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ext/openssl/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ def find_openssl_library
have_func("EVP_MD_CTX_get_pkey_ctx(NULL)", evp_h)
have_func("EVP_PKEY_eq(NULL, NULL)", evp_h)
have_func("EVP_PKEY_dup(NULL)", evp_h)
have_func("EVP_PKEY_get_size", evp_h)

# added in 3.2.0
have_func("SSL_get0_group_name(NULL)", ssl_h)
Expand Down
4 changes: 4 additions & 0 deletions ext/openssl/openssl_missing.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,8 @@
# define EVP_PKEY_eq(a, b) EVP_PKEY_cmp(a, b)
#endif

#ifndef HAVE_EVP_PKEY_GET_SIZE
# define EVP_PKEY_get_size(x) EVP_PKEY_size(x)
#endif

#endif /* _OSSL_OPENSSL_MISSING_H_ */
23 changes: 23 additions & 0 deletions ext/openssl/ossl_pkey.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,6 +1074,28 @@ ossl_pkey_compare(VALUE self, VALUE other)
ossl_raise(ePKeyError, "EVP_PKEY_eq");
}

/*
* call-seq:
* pkey.size -> integer
*
* Get the key size in bytes
*
* == Example
* rsa_key = OpenSSL::PKey::RSA.new(pem_encoded_private_key)
*
* rsa_key.size => 512
*/
static VALUE
ossl_pkey_size(VALUE self) {
int ret = 0;
EVP_PKEY *selfPKey;

GetPKey(self, selfPKey);
ret = EVP_PKEY_get_size(selfPKey);

return INT2NUM(ret);
}

/*
* call-seq:
* pkey.sign(digest, data [, options]) -> string
Expand Down Expand Up @@ -1760,6 +1782,7 @@ Init_ossl_pkey(void)
rb_define_method(cPKey, "raw_private_key", ossl_pkey_raw_private_key, 0);
rb_define_method(cPKey, "raw_public_key", ossl_pkey_raw_public_key, 0);
rb_define_method(cPKey, "compare?", ossl_pkey_compare, 1);
rb_define_method(cPKey, "size", ossl_pkey_size, 0);

rb_define_method(cPKey, "sign", ossl_pkey_sign, -1);
rb_define_method(cPKey, "verify", ossl_pkey_verify, -1);
Expand Down
14 changes: 14 additions & 0 deletions test/openssl/test_pkey.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,20 @@ def test_compare?
end
end

def test_size
key1 = Fixtures.pkey("rsa-1")
key2 = Fixtures.pkey("rsa-2")
key3 = Fixtures.pkey("p256")

assert_equal(512, key1.size)
assert_equal(512, key2.size)
assert_equal(72, key3.size)

# Should match the number of bits of the public component for RSA keys
assert_equal(key1.n.num_bits / 8, key1.size)
assert_equal(key1.n.num_bits / 8, key2.size)
end

def test_to_text
rsa = Fixtures.pkey("rsa-1")
assert_include rsa.to_text, "publicExponent"
Expand Down
Loading