Use RbConfig to locate libprism and headers when it is a default gem #3223
Conversation
eregon
commented
Nov 10, 2024
eregon
commented
- This is notably necessary on TruffleRuby, which is updating to Ruby 3.3 which introduces Prism as a default gem.
- Using the existing path is not an option as it would end up in truffleruby/lib/build/libprism.so and "truffleruby/lib/include/#{header}" which are not good places for such files.
* This is notably necessary on TruffleRuby, which is updating to Ruby 3.3 which introduces Prism as a default gem.
* Using the existing path is not an option as it would end up in truffleruby/lib/build/libprism.so and
"truffleruby/lib/include/#{header}" which are not good places for such files.
| INCLUDE_DIR = File.expand_path("../../include", __dir__) | ||
| ffi_lib libprism_in_build | ||
| else | ||
| INCLUDE_DIR = "#{RbConfig::CONFIG["libdir"]}/prism/include" |
There was a problem hiding this comment.
As a note I used libdir here and not includedir on purpose, those headers should not be reachable with C include statements and should not be mixed with Ruby C API headers.
|
@eregon I'm not sure if I'm reading this right, but it seems like when on the FFI backend this would favor the builtin Prism instead of the one bundled with the gem. Does that mean that on the FFI backend you can no longer upgrade the Prism gem version? |
|
It prefers the libprism in Also if this was wrong the CI would fail and the version checks would fail as well. |
|
Ahhh I see now, thanks! |
3 participants
