Reject assigning command call without parentheses #3245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
force-pushed
the
reject-assigning-command-call-without-parentheses
branch
5 times, most recently
from
7e133b9 to
57038f1
Compare
ydah
force-pushed
the
reject-assigning-command-call-without-parentheses
branch
from
57038f1 to
b045ab4
Compare
Member
|
It looks like this change has a legit test failure, can you take a look? |
kddnewton
requested changes
Dec 4, 2024
Collaborator
kddnewton
left a comment
kddnewton
left a comment
There was a problem hiding this comment.
I think this is something we'll want to fix with the accepts_command_call variable as opposed to validating later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3106