Fix parser translator ast for heredoc with written newlines #3347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
parser-translator-heredoc-newline-ast
branch
2 times, most recently
from
e58606d to
b2cd191
Compare
Collaborator
|
@Earlopain just to see this working as expected, would you mind rebasing this branch now that the other stuff is merged? |
Heredocs that contain "\\n" don't start a new string node.
Earlopain
force-pushed
the
parser-translator-heredoc-newline-ast
branch
from
b2cd191 to
61d9d3a
Compare
Collaborator
Author
|
Happy new year to you! Thanks for taking a look at the other PRs. Apologies for the scope and mishmash of things in those, I was largely working through tests and just seeing what they need to pass. Looks like this one is still good to go |
kddnewton
approved these changes
Jan 5, 2025
This was referenced Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heredocs don't don't start a new string node when encountering "\\n".
Builds on top of #3343, but only because the tokens would otherwise not line up. It's otherwise totally standalone. Will actually fix rubocop/rubocop#12878