Better handle multiline interpolated strings in the parser translator #3375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rubocop/rubocop#12870
For example:
The parser gem produces
While the translator wraps the last two string nodes in a dstr. There was already logic that kinda was supposed to handle this but it was too specific, applying only when the interpolation contains a single string node.
Much of this logic should be shared between interpolated symbols and regexps. It's also incorrect when the node contains a literal
\\n(same as for plain string nodes at the moment).After #3373 is merged, the added method for creating string nodes can be used to make it more correct in all of these cases.