Do not use 0 to indicate the latest ruby version to parse
#3605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it hard to do version checks against this value. The current version checks work because there are so few possible values, and they are exclusively
!=/==` checks.As an example, #3337 introduces new syntax for ruby 3.5 and uses
PM_OPTIONS_VERSION_LATESTas its version guard. Because what is considered the latest changes every year, it must later be changed toparser->version == parser->version == PM_OPTIONS_VERSION_CRUBY_3_5 || parser->version == PM_OPTIONS_VERSION_LATEST, with one extra version each year.With this change, the PR can instead write
parser->version >= PM_OPTIONS_VERSION_CRUBY_3_5which is self-explanatory and works for future versions.