Test against everything from CRuby #3684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't take that much longer. If a change in prism breaks CRuby tests, the PR should be made in ruby/ruby instead.
Github CI actually has 4 cores, this should be faster
Earlopain
force-pushed
the
full-ruby-ruby-testing
branch
from
6cf6be7 to
3c2bd26
Compare
Earlopain
changed the title
Collaborator
Author
|
I was hoping this triggers failures from #3679 but it seems it doesn't. Regardless, this should be ok to do. @tenderlove since you were asking: it doesn't take that long, only 7m30s vs 5m30s before. |
kddnewton
reviewed
Oct 16, 2025
Collaborator
kddnewton
left a comment
kddnewton
left a comment
There was a problem hiding this comment.
Yeah, this is a good idea. It will stop probably not take as long as memcheck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is a good idea, let's see if this works.