Ruby 4.0 #3709
Merged
Ruby 4.0 #3709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See ruby/ruby@6d81969 It leaves the old variant around. RuboCop for examples accesses `Prism::Translation::Parser35` to test against ruby-head. For now I left these simply as an alias
Earlopain
commented
Nov 7, 2025
Collaborator
Author
Earlopain
left a comment
Earlopain
left a comment
There was a problem hiding this comment.
CI will break in a day or two when ruby-dev becomes 4.0. But for now that hasn't happened yet, so I did not change anything there.
| PM_OPTIONS_VERSION_CRUBY_3_5 = 3, | ||
|
|
||
| /** The vendored version of prism in CRuby 4.0.x. */ | ||
| PM_OPTIONS_VERSION_CRUBY_4_0 = 3, |
Collaborator
Author
There was a problem hiding this comment.
No need to use a different number here than for "3.5". They are the same after all.
| V3_3(1), | ||
| V3_4(2), | ||
| V3_5(3); | ||
| V3_5(3), |
Collaborator
Author
There was a problem hiding this comment.
I have a use-case for keeping the 3.5 parser translator. While I can't say the same for the other places, I'd keep them all around for now.
In a year or two I'd simply remove them.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ruby/ruby@6d81969
It leaves the old variant around. RuboCop for examples accesses
Prism::Translation::Parser35to test against ruby-head. For now I left these simply as an alias