Skip to content

Optimize Prism::Source#find_line #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kddnewton merged 1 commit into from
Nov 29, 2025
Merged

Optimize Prism::Source#find_line #3758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions lib/prism/parse_result.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,21 +155,8 @@ def deep_freeze
# Binary search through the offsets to find the line number for the given
# byte offset.
def find_line(byte_offset)
left = 0
right = offsets.length - 1

while left <= right
mid = left + (right - left) / 2
return mid if (offset = offsets[mid]) == byte_offset

if offset < byte_offset
left = mid + 1
else
right = mid - 1
end
end

left - 1
index = offsets.bsearch_index { |offset| offset > byte_offset } || offsets.length
index - 1
end
end

Expand Down