Skip to content

Fix invalid Ruby code example in ClassNode comment #3761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eregon merged 1 commit into from
Nov 28, 2025
Merged

Fix invalid Ruby code example in ClassNode comment #3761

eregon merged 1 commit into from
Nov 28, 2025

Conversation

@qraqras
Copy link
Contributor

@qraqras qraqras commented Nov 28, 2025

Added a semicolon to make it valid Ruby code.

- class Foo end
+ class Foo; end

@eregon eregon merged commit d9b2917 into ruby:main Nov 28, 2025
64 checks passed
@eregon
Copy link
Member

eregon commented Nov 28, 2025

Thanks!

@kddnewton kddnewton mentioned this pull request Nov 29, 2025
Merged
@kddnewton
Copy link
Collaborator

kddnewton commented Nov 29, 2025

That syntax was valid! The point was to avoid semicolons if we could in the file, so reverting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eregon eregon eregon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qraqras @eregon @kddnewton