Set "trailing" on the comment node #3777
Closed
+32
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenderlove
force-pushed
the
trailing-comment
branch
2 times, most recently
from
d4362b3 to
f1ebb6a
Compare
Comment nodes can know if they are trailing comments by looking at the previous token. If we set this on the comment object then we don't need to look at source slices when attaching comments
tenderlove
force-pushed
the
trailing-comment
branch
from
f1ebb6a to
9f1bd7a
Compare
Collaborator
|
(Closing per our convo) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment nodes can know if they are trailing comments by looking at the previous token. If we set this on the comment object then we don't need to look at source slices when attaching comments