Percent array heredoc continuation #3778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://bugs.ruby-lang.org/issues/21756. Ripper fails to parse this, but prism actually also doesn't handle it correctly. When heredocs are used, even in lowercase percent arays there can be multiple `STRING_CONTENT` tokens. We need to concat them. Luckily we don't need to handle as many cases as in uppercase arrays where interpolation is allowed.
Not so sure how to trigger it but this is definitly more correct.
Earlopain
force-pushed
the
percent-array-heredoc-continuation
branch
2 times, most recently
from
3497ea8 to
1bc8ec5
Compare
Earlopain
commented
Dec 3, 2025
| pm_array_node_t *array = pm_array_node_create(parser, &opening); | ||
|
|
||
| // skip all leading whitespaces | ||
| accept1(parser, PM_TOKEN_WORDS_SEP); |
Collaborator
Author
There was a problem hiding this comment.
This was not needed, the loop already consumsed the separator. Removed because it was already not present in %i handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugs.ruby-lang.org/issues/21756. Ripper fails to parse this but prism actually also doesn't handle it correctly.
When heredocs are used, even in lowercase percent arays there can be
multiple
STRING_CONTENTtokens. We need to concat them.Luckily we don't need to handle as many cases as in uppercase arrays where interpolation is allowed. Mostly inspired by how uppercase arrays are handled.
%qstrings seem to work ok already.Second commit is a pretty small fix I noticed while I was poking around. Probably a copy-paste error.