Fix %Q with newline delimiter and heredoc interpolation
#3780
+158
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lexer did not jump to the `heredoc_end`, causing the heredoc end delimiter to be parsed twice. Normally the heredocs get flushed when a newline is encountered. But because the newline is part of the string delimiter, that codepath is not taken. Fixes [Bug #21758]
Earlopain
commented
Dec 4, 2025
| B | ||
|
|
||
| # \r\n | ||
| %Q |
Collaborator
Author
There was a problem hiding this comment.
Seems to just work without special handling, see snapshot for confirmation
Collaborator
Author
|
parse.y failure seems unrelated. I saw the same while I was syncing my fork. Might be fixed by ruby/ruby#15393, that is not in ruby-dev yet. |
kddnewton
approved these changes
Dec 4, 2025
Collaborator
kddnewton
left a comment
kddnewton
left a comment
There was a problem hiding this comment.
Thank you! I really didn't want to look into this one...
Collaborator
Author
|
Gee, I wonder why 😅. Does seem like a bit of a waste of time to fix but I got to poke around in an area which I didn't really pay much attention to before. Your heredoc documentation was pretty helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lexer did not jump to the
heredoc_end, causing the heredoc end delimiter to be parsed twice.Normally the heredocs get flushed when a newline is encountered. But because the newline is part of the string delimiter, that codepath is not taken.
Fixes [Bug #21758]
Actually also depends on #3771. While the issue was only about syntax-invalid code, this would also hit the assertion. Quite fortunate (for me) that this was not a problem anymore (;