Define RubyParser::SyntaxError so we don't have to require ruby_parser anymore #3800
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I have a failure in rust bindings. That's green on main. Is is flaky or what? |
zenspider
force-pushed
the
zenspider__fix_ruby_parser_dependency
branch
3 times, most recently
from
b91bac2 to
9389843
Compare
zenspider
changed the title
Earlopain
requested changes
Dec 13, 2025
lib/prism/translation/ruby_parser.rb
Outdated
| rescue LoadError | ||
| warn(%q{Error: Unable to load ruby_parser. Add `gem "ruby_parser"` to your Gemfile.}) | ||
| exit(1) | ||
| require "sexp" |
Collaborator
There was a problem hiding this comment.
Let's tweak the begin/rescue instead of removing it. I think I am ok to drop the hard requirement on ruby_parser since it only depends on that one exception but the error message for missing sexp_processor should still be present.
lib/prism/translation/ruby_parser.rb
Outdated
| require "sexp" | ||
|
|
||
| class RubyParser # :nodoc: | ||
| SyntaxError = Class.new RuntimeError # :nodoc: |
Collaborator
There was a problem hiding this comment.
This avoids a redeclared constant warning if ruby_parser ends up being loaded first anyways.
Suggested change
| SyntaxError = Class.new RuntimeError # :nodoc: | |
| class SyntaxError < RuntimeError; end # :nodoc: |
…ser. Had to add a require of sexp since that came in indirectly via ruby_parser.
kddnewton
force-pushed
the
zenspider__fix_ruby_parser_dependency
branch
from
9389843 to
df677c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd rather there be no require whatesoever as the SyntaxError class
there is basic af... but this guard should do the trick.