Skip to content

Skip tests that are obsolete after CGI removal #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soutaro merged 1 commit into from
May 15, 2025
Merged

Skip tests that are obsolete after CGI removal #2482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
161 changes: 84 additions & 77 deletions test/stdlib/CGI_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,37 +7,6 @@ class CGISingletonTest < Test::Unit::TestCase
library "cgi"
testing "singleton(::CGI)"

def test_new
ARGV.replace(%w(abc=001 def=002))
assert_send_type "() -> void",
CGI, :new
assert_send_type "(?::String options) -> void",
CGI, :new, 'html3'
assert_send_type "(?::String options) ?{ (::String name, ::String value) -> void } -> void",
CGI, :new, 'html3' do |name, value| name + value end
assert_send_type "(::Hash[::Symbol, untyped] options_hash) -> void",
CGI, :new, { tag_maker: 'html5', max_multipart_length: 2048 }
assert_send_type "(::Hash[::Symbol, untyped] options_hash) ?{ (::String name, ::String value) -> void } -> void",
CGI, :new, { tag_maker: 'html5', max_multipart_length: 2048 } do |name, value| name + value end
end

def test_accept_charset
assert_send_type "() -> ::encoding",
CGI, :accept_charset
end

def test_accept_charset=
assert_send_type "(::String accept_charset) -> ::String",
CGI, :accept_charset=, 'utf-8'
assert_send_type "(::Encoding accept_charset) -> ::Encoding",
CGI, :accept_charset=, Encoding::UTF_8
end

def test_parse
assert_send_type "(::String query) -> ::Hash[::String, String | Array[String]]",
CGI, :parse, 'a=hoge&b=1&c[]=test1&c[]=test2'
end

def test_escapeURIComponent
assert_send_type(
"(String) -> String",
Expand All @@ -59,6 +28,41 @@ def test_unescapeURIComponent
CGI, :unescapeURIComponent, ToStr.new("hogehoge")
)
end

# These methods are removed in Ruby 3.5.
unless RUBY_VERSION >= "3.5"
def test_new
ARGV.replace(%w(abc=001 def=002))
assert_send_type "() -> void",
CGI, :new

assert_send_type "(?::String options) -> void",
CGI, :new, 'html3'
assert_send_type "(?::String options) ?{ (::String name, ::String value) -> void } -> void",
CGI, :new, 'html3' do |name, value| name + value end
assert_send_type "(::Hash[::Symbol, untyped] options_hash) -> void",
CGI, :new, { tag_maker: 'html5', max_multipart_length: 2048 }
assert_send_type "(::Hash[::Symbol, untyped] options_hash) ?{ (::String name, ::String value) -> void } -> void",
CGI, :new, { tag_maker: 'html5', max_multipart_length: 2048 } do |name, value| name + value end
end

def test_accept_charset
assert_send_type "() -> ::encoding",
CGI, :accept_charset
end

def test_accept_charset=
assert_send_type "(::String accept_charset) -> ::String",
CGI, :accept_charset=, 'utf-8'
assert_send_type "(::Encoding accept_charset) -> ::Encoding",
CGI, :accept_charset=, Encoding::UTF_8
end

def test_parse
assert_send_type "(::String query) -> ::Hash[::String, String | Array[String]]",
CGI, :parse, 'a=hoge&b=1&c[]=test1&c[]=test2'
end
end
end

class CGITest < Test::Unit::TestCase
Expand All @@ -76,51 +80,54 @@ def test_print
CGI.new, :print, ''
end

def test_http_header
assert_send_type "() -> ::String",
CGI.new, :http_header
assert_send_type "(::String options) -> ::String",
CGI.new, :http_header, 'text/csv'
assert_send_type "(::Hash[::String, untyped] header_hash) -> ::String",
CGI.new, :http_header, { 'type' => 'text/csv', 'nph' => false, 'length' => 1024 }
assert_send_type "(::Hash[::Symbol, untyped] header_hash) -> ::String",
CGI.new, :http_header, { type: 'text/csv', nph: false, length: 1024 }
end

def test_header
assert_send_type "() -> ::String",
CGI.new, :header
assert_send_type "(::String options) -> ::String",
CGI.new, :header, 'text/csv'
assert_send_type "(::Hash[::String, untyped] header_hash) -> ::String",
CGI.new, :header, { 'type' => 'text/csv', 'nph' => false, 'length' => 1024 }
assert_send_type "(::Hash[::Symbol, untyped] header_hash) -> ::String",
CGI.new, :header, { type: 'text/csv', nph: false, length: 1024 }
end

def test_nph?
assert_send_type "() -> ::boolish",
CGI.new, :nph?
end

def test_out
assert_send_type "() { () -> void } -> void",
CGI.new, :out do '' end
assert_send_type "(::String content_type_string) { () -> String } -> void",
CGI.new, :out, 'text/csv' do '' end
assert_send_type "(::Hash[::String, untyped] header_hash) { () -> String } -> void",
CGI.new, :out, { 'type' => 'text/csv', 'nph' => false, 'length' => 1024 } do '' end
assert_send_type "(::Hash[::String | ::Symbol, untyped] header_hash) { () -> String } -> void",
CGI.new, :out, { type: 'text/csv' } do '' end
end

def test_stdinput
assert_send_type "() -> ::IO",
CGI.new, :stdinput
end

def test_stdoutput
assert_send_type "() -> ::IO",
CGI.new, :stdoutput
# These methods are removed in Ruby 3.5.
unless RUBY_VERSION >= "3.5"
def test_http_header
assert_send_type "() -> ::String",
CGI.new, :http_header
assert_send_type "(::String options) -> ::String",
CGI.new, :http_header, 'text/csv'
assert_send_type "(::Hash[::String, untyped] header_hash) -> ::String",
CGI.new, :http_header, { 'type' => 'text/csv', 'nph' => false, 'length' => 1024 }
assert_send_type "(::Hash[::Symbol, untyped] header_hash) -> ::String",
CGI.new, :http_header, { type: 'text/csv', nph: false, length: 1024 }
end

def test_header
assert_send_type "() -> ::String",
CGI.new, :header
assert_send_type "(::String options) -> ::String",
CGI.new, :header, 'text/csv'
assert_send_type "(::Hash[::String, untyped] header_hash) -> ::String",
CGI.new, :header, { 'type' => 'text/csv', 'nph' => false, 'length' => 1024 }
assert_send_type "(::Hash[::Symbol, untyped] header_hash) -> ::String",
CGI.new, :header, { type: 'text/csv', nph: false, length: 1024 }
end

def test_nph?
assert_send_type "() -> ::boolish",
CGI.new, :nph?
end

def test_out
assert_send_type "() { () -> void } -> void",
CGI.new, :out do '' end
assert_send_type "(::String content_type_string) { () -> String } -> void",
CGI.new, :out, 'text/csv' do '' end
assert_send_type "(::Hash[::String, untyped] header_hash) { () -> String } -> void",
CGI.new, :out, { 'type' => 'text/csv', 'nph' => false, 'length' => 1024 } do '' end
assert_send_type "(::Hash[::String | ::Symbol, untyped] header_hash) { () -> String } -> void",
CGI.new, :out, { type: 'text/csv' } do '' end
end

def test_stdinput
assert_send_type "() -> ::IO",
CGI.new, :stdinput
end

def test_stdoutput
assert_send_type "() -> ::IO",
CGI.new, :stdoutput
end
end
end