Skip to content

Conversation

@soutaro
Copy link
Member

@soutaro soutaro commented Dec 17, 2025

claude-code fixed the problems:

  1. include/rbs/parser.h: Renamed field rbs_lexer_t *rbs_lexer_t to rbs_lexer_t *lexer to avoid using the type name as a field name (invalid in C++).
  2. src/parser.c:
    - Updated all references from ->rbs_lexer_t to ->lexer
    - Updated struct initializer from .rbs_lexer_t to .lexer
    - Renamed local variables named namespace to ns or out_ns (since namespace is a C++ keyword)
    - Fixed the INTERN_TOKEN macro by removing the unnecessary (void *) cast
    - Added explicit (TypeNameKind) casts for bitwise OR operations on enum values
  3. src/location.c: Added explicit cast for rbs_allocator_malloc_impl return value
  4. src/util/rbs_allocator.c: Added explicit casts for malloc return values to rbs_allocator_page_t * and rbs_allocator_t *
  5. src/util/rbs_constant_pool.c: Added explicit casts for void pointer assignments to rbs_constant_pool_bucket_t * and rbs_constant_t *
  6. ext/rbs_extension/legacy_location.c: Added explicit casts for malloc, realloc, and rb_check_typeddata return values
  7. ext/rbs_extension/class_constants.c: Removed duplicate declaration of RBS_Parser

claude-code fixed the problems:

  1. include/rbs/parser.h: Renamed field rbs_lexer_t *rbs_lexer_t to rbs_lexer_t *lexer to avoid using the type name as a field name (invalid in C++).
  2. src/parser.c:
    - Updated all references from ->rbs_lexer_t to ->lexer
    - Updated struct initializer from .rbs_lexer_t to .lexer
    - Renamed local variables named namespace to ns or out_ns (since namespace is a C++ keyword)
    - Fixed the INTERN_TOKEN macro by removing the unnecessary (void *) cast
    - Added explicit (TypeNameKind) casts for bitwise OR operations on enum values
  3. src/location.c: Added explicit cast for rbs_allocator_malloc_impl return value
  4. src/util/rbs_allocator.c: Added explicit casts for malloc return values to rbs_allocator_page_t * and rbs_allocator_t *
  5. src/util/rbs_constant_pool.c: Added explicit casts for void pointer assignments to rbs_constant_pool_bucket_t * and rbs_constant_t *
  6. ext/rbs_extension/legacy_location.c: Added explicit casts for malloc, realloc, and rb_check_typeddata return values
  7. ext/rbs_extension/class_constants.c: Removed duplicate declaration of RBS_Parser
@soutaro soutaro added this to the RBS 4.0 milestone Dec 17, 2025
@soutaro soutaro added the to-backport:3.10 PRs to be backported to 3.10 label Dec 17, 2025
@soutaro soutaro enabled auto-merge December 17, 2025 01:56
@soutaro soutaro merged commit 6612142 into master Dec 17, 2025
21 of 22 checks passed
@soutaro soutaro deleted the cpp-warnings branch December 17, 2025 01:59
soutaro added a commit that referenced this pull request Dec 17, 2025
@soutaro soutaro removed the to-backport:3.10 PRs to be backported to 3.10 label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants