Prevent style rendering in code blocks #1536
Merged
+56
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🚀 Preview deployment available at: https://5767306a.rdoc-6cd.pages.dev (commit: bde3f30) |
st0012
commented
Dec 31, 2025
| "_#{PROTECT_ATTR}_#{PROTECT_ATTR}\\1_#{PROTECT_ATTR}_#{PROTECT_ATTR}") | ||
| @str.gsub!(/(\A|[^\\])\\([#{Regexp.escape @protectable.join}])/m, | ||
| "\\1\\2#{PROTECT_ATTR}") | ||
| @str.gsub!(/\\(\\[#{Regexp.escape @protectable.join}])/m, "\\1") |
Member
Author
There was a problem hiding this comment.
There's a lot of repeated regexp creation like this in this file. I think most of them can be extracted into ivars.
tompng
approved these changes
Jan 1, 2026
st0012
added a commit
that referenced
this pull request
Jan 4, 2026
1. README now has a better section about supported markup formats 2. RDoc markup related reference are now consolidated under `doc/markup_reference/rdoc.rdoc` 3. Markdown markup now has a more comprehensive reference in `doc/markup_reference/markdown.md` (#1536, #1538, #1540, and #1541 were all discovered when I was preparing for this PR 😄)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After