Extract TruffleRuby workflow from reline.yml #783
Conversation
st0012
left a comment
st0012
left a comment
There was a problem hiding this comment.
The build doesn't actually run tho: https://github.com/ruby/reline/actions/runs/12053375836
| ruby-versions: | ||
| uses: ruby/actions/.github/workflows/ruby_versions.yml@master | ||
| with: | ||
| engine: truffleruby |
There was a problem hiding this comment.
I may be wrong, but I don't think there's a truffleruby engine.
Yes I'm wrong. I'll update IRB's action.
There was a problem hiding this comment.
Actually, I'm wrong on being wrong 🤦♂️
If we use the setup-ruby action, then truffleruby is indeed supported. But since we're using ruby_versions, I think only these are supported.
There was a problem hiding this comment.
Thanks for your review! I've fixed.
engine: cruby-truffleruby
ruby: [truffleruby-head]
| fail-fast: false | ||
| matrix: | ||
| ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }} | ||
| os: [ubuntu-latest, macos-latest, windows-latest] |
There was a problem hiding this comment.
With the below exclusions, we'll only run ubuntu-latest after all. Maybe let's just update this list to that and remove the excludes?
ima1zumi
force-pushed
the
extract-truffleruby-workflow
branch
2 times, most recently
from
a39b7c9 to
0043baf
Compare
ima1zumi
force-pushed
the
extract-truffleruby-workflow
branch
from
0043baf to
cbc95ac
Compare
| on: | ||
| push: | ||
| pull_request: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
I made it possible to check the CI status manually.
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ruby: [truffleruby-head] |
There was a problem hiding this comment.
truffleruby-head was originally excluded, but since it can now be easily stopped, it has been set to truffleruby-head.
| env: | ||
| TERM: xterm-256color | ||
| run: bundle exec rake test RUBYOPT="--enable-frozen-string-literal" | ||
|
|
There was a problem hiding this comment.
Readline tests were removed because they were not being run on TruffleRuby.
2 participants
Background: ruby/irb#1032
Ref: ruby/irb#1035
Similar to IRB, I have separated the TruffleRuby workflow from reline.yml.