Skip to content

Conversation

@nobu
Copy link
Member

@nobu nobu commented Jan 1, 2025

What was the end-user or developer problem that led to this PR?

Should be nothing.

What is your fix for the problem, implemented in this PR?

"lib/rubygems/vendor/*" directories have the same ".document" files.
But shouldn't vendored things be ignored totally?

Make sure the following tasks are checked

@deivid-rodriguez
Copy link
Contributor

Makes sense to me!

You need to update the Manifest.txt file though by running bin/rake update_manifest, and also, we should make sure our vendor script no longer generates this file, i.e., remove this line.

@deivid-rodriguez
Copy link
Contributor

Thank you @nobu. This idea made sense to me, so I updated it with my small suggestions and will merge it.

@simi simi enabled auto-merge January 27, 2025 17:42
@simi simi merged commit 6a48202 into ruby:master Jan 27, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants